feat(cronet_http): support streaming request bodies on StreamedRequest - #1941
Open
hasanmhallak wants to merge 3 commits into
Open
hasanmhallak wants to merge 3 commits into
hasanmhallak wants to merge 3 commits into
Conversation
- Add streaming upload support for `StreamedRequest` in `CronetClient` using Cronet's `UploadDataProvider` API instead of buffering the full body with `stream.toBytes()`. - Introduce `UploadDataProviderProxy` (Kotlin) so Dart can implement Cronet's abstract `UploadDataProvider` via JNI, following the same pattern as `UrlRequestCallbackProxy`. - Regenerate JNI bindings for `UploadDataProvider`, `UploadDataSink`, and `UploadDataProviderProxy`; add `package:async` for `StreamQueue`. - Keep the existing in-memory upload path for `Request` bodies unchanged. - Enable streamed request body conformance tests (`canStreamRequestBody: true`). - Bump `cronet_http` to `1.10.0`.
Contributor
Author
|
any update on this? |
brianquinlan
self-requested a review
September 21, 2026 21:36
brianquinlan
requested changes
Sep 21, 2026
brianquinlan
left a comment
brianquinlan
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the delayed review, I'm working through the backlog.
Return the upload length from Kotlin so getLength does not block the Cronet thread, release the JNI refs on the upload callbacks, and always answer UploadDataSink. Cancel the body stream on failure and close, not when response headers arrive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamedRequestinCronetClientusing Cronet'sUploadDataProviderAPI instead of buffering the full body withstream.toBytes().UploadDataProviderProxy(Kotlin) so Dart can implement Cronet's abstractUploadDataProvidervia JNI, following the same pattern asUrlRequestCallbackProxy.UploadDataProvider,UploadDataSink, andUploadDataProviderProxy; addpackage:asyncforStreamQueue.Requestbodies unchanged.canStreamRequestBody: true).cronet_httpto1.10.0.relevant #1084
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.