allow widgets in sections and collapsibles and curve widgets to mark tabs as changed - #22004
Open
piratenpanda wants to merge 3 commits into
Open
allow widgets in sections and collapsibles and curve widgets to mark tabs as changed#22004piratenpanda wants to merge 3 commits into
piratenpanda wants to merge 3 commits into
Conversation
Collaborator
|
Did some (limited) testing: Seems to fix what it sets out to fix :-) . |
Member
|
@piratenpanda : The module color equalizer don't work - no highlight when curve change and no reset by double-click on tab - (not working before this PR), maybe a good time to fix the tab on this module. Likewise for "denoise profile" and "contrast equalizer". |
Contributor
Author
|
@TurboGit latest commit adds this functionality. If it's the most elegant solution I don't know. |
piratenpanda
changed the title
Contributor
Author
|
loading presets does not trigger this, will investigate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the spektrafilm module I noticed that widgets in sections and collapsibles don't mark the tab state as changed and also don't allow widgets to be reset by double clicking. This PR brings deeper parsing and also provides functionality to exclude certain widgets like the ones in the color calibration collapsibles to not mark the tab as changed and also not resettable as this is wanted in this specific case. I tested AgX and Filmic and both behave like expected for me but some more testing on other systems might be good.
Co-created with Claude Opus 5.0