fix: main CI failures after the audit merges - #394
Merged
Merged
Conversation
…lized dev app name in menu bar tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the two failures on main after the audit PRs merged.
data:URLs. The MCP SDK turns any string argument that looks like adata:URL into binary data. The tool catalog then passed it on as bare base64, so a browser tool given adata:text/html,...URL got garbage. It now re-encodes the value as a data URL with its MIME type. This is whattest_mcp_server_e2e.pycaught once test: run the programa-mcp e2e test in the PR subset again #382 put it back in CI.Programa DEV, and three test expectations still saidprograma DEV.Test plan
socket-integration-testspasses, includingtest_mcp_server_e2e.pyunit-testspasses, includingNotificationAndMenuBarTests