Repository navigation
[Backport release-1.19] test(health): measure the health check timeout with time.monotonic() - #1330
Merged
Merged
Conversation
…1328) DaprHealth computes its deadline with time.monotonic(), but the tests measured the elapsed time with time.time(). On Windows the two clocks have different resolutions, so the >= 2.5 check failed now and then (2.4987 s) although the code waited the full timeout. Use the same clock in the tests. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 02e3f00) Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>
dapr-bot
added
automerge
dapr-bot
enabled auto-merge (squash)
October 21, 2026 14:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #1330 +/- ##
===============================================
Coverage ? 87.15%
===============================================
Files ? 163
Lines ? 13066
Branches ? 0
===============================================
Hits ? 11388
Misses ? 1678
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CasperGN
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 02e3f00 from #1328.