Repository navigation
ci(release): check VERSION before creating a release tag - #1321
Merged
dapr-bot merged 5 commits intoOct 20, 2026
Merged
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1321 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 163 163
Lines 13069 13069
=======================================
Hits 11406 11406
Misses 1663 1663 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sicoyle
added
backport release-1.19
automerge
dapr-bot
enabled auto-merge
October 20, 2026 22:41
CasperGN
approved these changes
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
dapr-bot
added a commit
that referenced
this pull request
Oct 21, 2026
* feat(release): add a VERSION readiness check for release tags * ci(release): reuse the VERSION check in the publish workflow * ci(release): gate tag creation on VERSION matching the release * fix: address review — harden release version check and tag workflow --------- (cherry picked from commit f784843) Signed-off-by: Samantha Coyle <sam@diagrid.io> Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com> Co-authored-by: Sam Kendziora <sam@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tags are now created by a new
dapr-python-release-tagworkflow. Before it pushesvX.Y.Zwith the bot token, it checks thatVERSIONon therelease-X.Ybranch matches the version being released, belongs to thatX.Yline, isn't.dev, and hasn't been tagged yet. The publish workflow uses the same check, and RELEASE.md now describes this flow.Until now, the tag-vs-VERSION check only ran after a tag had been pushed by hand.
v1.19.0rc2andv1.19.0rc3were both pushed onto a commit whoseVERSIONstill said1.19.0rc1, so both releases failed after the tags existed.Tested with unit tests for the check script, by replaying the rc2 case through it, and with actionlint on both workflows.
🤖 Generated with Claude Code