Speed up CI#1134
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 86.63% 82.20% -4.43%
==========================================
Files 84 117 +33
Lines 4473 9612 +5139
==========================================
+ Hits 3875 7902 +4027
- Misses 598 1710 +1112 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces end-to-end CI time by removing fixed sleeps in example/integration test infrastructure and replacing them with readiness/condition-based waits, plus speeding up Ollama setup in the GitHub Actions workflow.
Changes:
- Replace fixed
wait=Nsleeps in example tests with Dapr sidecar readiness polling (viaDaprRunner.start). - Make the Kafka-backed invoke-binding example wait on topic availability instead of a flat sleep.
- Speed up CI Ollama setup by downloading/extracting the release tarball and polling the HTTP API for readiness.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/examples/test_w3c_tracing.py | Removes fixed startup wait in favor of runner readiness logic. |
| tests/examples/test_state_store_query.py | Removes fixed startup wait for the demo sidecar. |
| tests/examples/test_pubsub_streaming.py | Removes fixed startup waits for streaming pubsub tests. |
| tests/examples/test_pubsub_streaming_async.py | Removes fixed startup waits for async streaming pubsub tests. |
| tests/examples/test_pubsub_simple.py | Removes fixed startup wait for simple pubsub test. |
| tests/examples/test_jobs.py | Switches to run(..., until=...) to stop when expected output appears. |
| tests/examples/test_invoke_simple.py | Removes fixed startup wait for invoke receiver. |
| tests/examples/test_invoke_http.py | Removes fixed startup wait for HTTP invoke receiver. |
| tests/examples/test_invoke_custom_data.py | Removes fixed startup wait for invoke receiver. |
| tests/examples/test_invoke_binding.py | Replaces flat Kafka sleep with polling for topic availability before starting daprd. |
| tests/examples/test_grpc_proxying.py | Removes fixed startup wait for gRPC proxying receiver. |
| tests/examples/test_demo_actor.py | Removes fixed startup wait for demo_actor service. |
| tests/examples/test_configuration.py | Removes fixed startup wait for configuration example. |
| tests/examples/test_dapr_runner.py | Adds coverage for readiness polling behavior and updates retry sleep expectations. |
| tests/examples/conftest.py | Implements sidecar readiness polling in DaprRunner.start and increases default wait budget. |
| examples/demo_actor/README.md | Updates expected output to reflect reduced demo wait time. |
| examples/demo_actor/demo_actor/demo_actor_client.py | Reduces demo sleep from 30s to 12s to speed the example/test. |
| .github/workflows/run-tests.yaml | Speeds up Ollama install and replaces fixed sleeps with readiness polling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:

7m 32s
After (this PR):

5m 33s