Skip to content

Speed up CI#1134

Merged
sicoyle merged 1 commit into
dapr:mainfrom
acroca:speed-ci
Jul 9, 2026
Merged

Speed up CI#1134
sicoyle merged 1 commit into
dapr:mainfrom
acroca:speed-ci

Conversation

@acroca

@acroca acroca commented Jul 9, 2026

Copy link
Copy Markdown
Member
  • Faster ollama install
  • Reduced waiting times in demo_actor
  • Polling for sidecar readyness instead of flat wait.
  • Polling for kafka topics instead of flat wait.

Before:
image

7m 32s

After (this PR):
image

5m 33s

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.20%. Comparing base (bffb749) to head (6e9f0a6).
⚠️ Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   86.63%   82.20%   -4.43%     
==========================================
  Files          84      117      +33     
  Lines        4473     9612    +5139     
==========================================
+ Hits         3875     7902    +4027     
- Misses        598     1710    +1112     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca marked this pull request as ready for review July 9, 2026 07:24
@acroca acroca requested review from a team as code owners July 9, 2026 07:24
@acroca acroca requested a review from Copilot July 9, 2026 07:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces end-to-end CI time by removing fixed sleeps in example/integration test infrastructure and replacing them with readiness/condition-based waits, plus speeding up Ollama setup in the GitHub Actions workflow.

Changes:

  • Replace fixed wait=N sleeps in example tests with Dapr sidecar readiness polling (via DaprRunner.start).
  • Make the Kafka-backed invoke-binding example wait on topic availability instead of a flat sleep.
  • Speed up CI Ollama setup by downloading/extracting the release tarball and polling the HTTP API for readiness.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/examples/test_w3c_tracing.py Removes fixed startup wait in favor of runner readiness logic.
tests/examples/test_state_store_query.py Removes fixed startup wait for the demo sidecar.
tests/examples/test_pubsub_streaming.py Removes fixed startup waits for streaming pubsub tests.
tests/examples/test_pubsub_streaming_async.py Removes fixed startup waits for async streaming pubsub tests.
tests/examples/test_pubsub_simple.py Removes fixed startup wait for simple pubsub test.
tests/examples/test_jobs.py Switches to run(..., until=...) to stop when expected output appears.
tests/examples/test_invoke_simple.py Removes fixed startup wait for invoke receiver.
tests/examples/test_invoke_http.py Removes fixed startup wait for HTTP invoke receiver.
tests/examples/test_invoke_custom_data.py Removes fixed startup wait for invoke receiver.
tests/examples/test_invoke_binding.py Replaces flat Kafka sleep with polling for topic availability before starting daprd.
tests/examples/test_grpc_proxying.py Removes fixed startup wait for gRPC proxying receiver.
tests/examples/test_demo_actor.py Removes fixed startup wait for demo_actor service.
tests/examples/test_configuration.py Removes fixed startup wait for configuration example.
tests/examples/test_dapr_runner.py Adds coverage for readiness polling behavior and updates retry sleep expectations.
tests/examples/conftest.py Implements sidecar readiness polling in DaprRunner.start and increases default wait budget.
examples/demo_actor/README.md Updates expected output to reflect reduced demo wait time.
examples/demo_actor/demo_actor/demo_actor_client.py Reduces demo sleep from 30s to 12s to speed the example/test.
.github/workflows/run-tests.yaml Speeds up Ollama install and replaces fixed sleeps with readiness polling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sicoyle sicoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing - thank you!!

@sicoyle sicoyle added this pull request to the merge queue Jul 9, 2026
Merged via the queue into dapr:main with commit 49b86a7 Jul 9, 2026
18 of 19 checks passed
@acroca acroca deleted the speed-ci branch July 9, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants