Conversation
Marketen
changed the title
Marketen
added a commit
that referenced
this pull request
Sep 9, 2026
Replaces the hand-maintained SHA with the pattern every other Dappnode package already uses: upstreamVersion names an upstream release, and the bump bot opens the PR. Hermes tracks NousResearch/hermes-agent exactly this way. The SDK had nothing to point at, which is the only reason a SHA was there in the first place; dappnode/dappnode-nexus-sdk#11 makes it cut a release on every merge to main. - upstreamVersion becomes v0.1.0 and the Dockerfile takes a release tag, validating the shape and fetching refs/tags/. - auto_check.yml calls dappnode/workflows bump-upstream, same as Hermes, so a new SDK release arrives as a PR rather than someone noticing. - NEXUS_SDK_TOKEN goes: the SDK is public, so the secret mount in the Dockerfile, the compose secrets block and both workflow env entries were all dead. Supersedes #14. - The release job gains needs: build-test. It had none, so a failing build test did not stop a publish. Open since the 24 August notes. Verified: the tag shape check accepts v0.1.0 and rejects a SHA, a bare branch name and a two-part version; fetching refs/tags/ resolves against a repository that has tags; manifest and compose pass dappmanager validation. The image itself cannot build until the first SDK release exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
This draft currently targets SDK commit
d49c902f480ae0db34e2c0621b0ef13384e992f0from dappnode/dappnode-nexus-sdk#6. Keep it as a draft until that PR is merged and the SDK repository is public. Before merging this PR, pinUPSTREAM_VERSIONto the final commit on SDKmainif the SDK PR is squash-merged, then rerun the full image build.The current Build test failure is expected: the container performs an unauthenticated fetch while the SDK repository is still private.
The removed technical README has been preserved outside the repository for maintainers.
Validation
docker compose config --quiet