Add nexus-proofs as an optional dependency of core - #221
Merged
Merged
Conversation
Nexus Proofs is a dncore package that not every node has. Listing it under optionalDependencies means a core update only moves it to the pinned version on nodes that already have it installed; nodes without it are unaffected. The release workflow gets a nexus_proofs input so the pin is bumped the same way as the other core packages. That brings workflow_dispatch to 10 inputs, which is GitHub's limit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nexus-proofs.dnp.dappnode.eth0.1.0 tooptionalDependencies, and anexus_proofsinput to the release workflow so its pin is bumped like the other core packages.How optional dependencies behave
When the dappmanager resolves core,
DappGetFetcher.dependenciesin the installer package adds an optional dependency to the dependency set only if that package is already installed on the node:The ISO installer (
dappnode_install.sh) uses a hardcoded package list, so fresh installs do not get Nexus Proofs either.Things to know
ErrorDappGetDowngradeandgetCoreUpdateDatareports no core update for that node. Nexus Proofs is not in the dappmanager'scorePackagesNotAutoupdatable, so it can also update on its own (per-package auto-update or the store). Bump this pin whenever Nexus Proofs is released.workflow_dispatchnow has 10 inputs, which is GitHub's limit. Adding another core package to this workflow will require restructuring it, for example by passing all versions in one JSON input.🤖 Generated with Claude Code