DAOS-19537 array: fix set_size at chunk boundaries - #18905
Open
yangck125 wants to merge 1 commit into
Open
Conversation
daos_array_set_size() skips the target dkey when its retained record index is zero. Shrinking to k * chunk_size + 1 therefore leaves extents after the new EOF, and daos_array_get_size() continues to report the old size. Process the target dkey regardless of the record index so records after the new EOF are punched and the retained record is checked. Add regression coverage for sizes 1 and chunk_size + 1, including size queries after reopening the array. Signed-off-by: Changke Yang <yangck125@163.com>
|
Ticket title is 'Array: daos_array_set_size() fails to shrink at chunk boundaries' |
6 tasks
mchaarawi
approved these changes
Aug 20, 2026
mchaarawi
left a comment
mchaarawi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the test and fix. it looks reasonable to me.
I have pushed the PR internally to get overall CI test result. once that passes i can land your PR to master.
daltonbohning
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daos_array_set_size()skips the target dkey when the retained record index is zero. Shrinking tok * chunk_size + 1therefore leaves extents after the new EOF, anddaos_array_get_size()continues to report a stale size.Process the target dkey even when
record_i == 0so records after the new EOF are punched and the retained record is checked. Add regression coverage for sizes1andchunk_size + 1, including size queries after reopening the array.Steps for the author:
After all prior steps are complete: