DAOS-19396 pool: mind pool_discard() dss_rpc_send() errors - #18901
Draft
kccain wants to merge 1 commit into
Draft
Conversation
Before this change, ds_pool_update_handler() for reintegration pool_discard() swallowed a nonzero rc returned by dss_rpc_send() for the POOL_TGT_DISCARD corpc. The code execution continued forward to perform pool map update (transition reintegrating engine targets to UP state). With this change, the code does *not* proceed to pool map update when the dss_rpc_send() call returns an error (e.g., -DER_TIMEDOUT). This gives retries either by the MS host daos_engine dsc_pool_client or by the test program itself (re-issuing the dmg pool reintegrate command) a chance to wait out and possibly recover from whatever communication failures are occurring among some engines and the (recently-restarted) reintegrating engine. Features: pool Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
|
Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_rebuild_ec - pool reintegrate timeout' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, ds_pool_update_handler() for reintegration pool_discard() swallowed a nonzero rc returned by dss_rpc_send() for the POOL_TGT_DISCARD corpc. The code execution continued forward to perform pool map update (transition reintegrating engine targets to UP state).
With this change, the code does not proceed to pool map update when the dss_rpc_send() call returns an error (e.g., -DER_TIMEDOUT).
This gives retries either by the MS host daos_engine dsc_pool_client or by the test program itself (re-issuing the dmg pool reintegrate command) a chance to wait out and possibly recover from whatever communication failures are occurring among some engines and the (recently-restarted) reintegrating engine.
Features: pool
Steps for the author:
After all prior steps are complete: