DAOS-19518 test: nvme/fault.py - Update timeout and delay - #18898
Draft
shimizukko wants to merge 1 commit into
Draft
DAOS-19518 test: nvme/fault.py - Update timeout and delay#18898shimizukko wants to merge 1 commit into
shimizukko wants to merge 1 commit into
Conversation
test_nvme_fault sets NVMe devices faulty. If the device is an sysXs device, "storage set nvme-faulty" command would fail, which is expected. The issue is that if we call dmg pool query (to check rebuild status) immeidately after the nvme-faulty command failure, the pool query command may timeout (after 5 min.). If pool query times out, we should retry. To enable the retry, set pool_query_timeout larger than 5 min, say 330 sec. Another way that could avoid this issue is to add some sleep between nvme-faulty and pool query. We already have a variable for this in TestPool, pool_query_delay, so set some time to it in the test yaml and move the sleep code in query() to right before calling pool query. Skip-fault-injection-test: true Skip-func-hw-test-large: false Test-tag: test_nvme_fault Test-repeat: 3 Signed-off-by: Makito Kano <makito.kano@hpe.com>
|
Ticket title is 'nvme/fault.py:NvmeFault.test_nvme_fault - pool query timeout detecting rebuild' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_nvme_fault sets NVMe devices faulty. If the device is an sysXs device, "storage set nvme-faulty" command would fail, which is expected.
The issue is that if we call dmg pool query (to check rebuild status) immeidately after the nvme-faulty command failure, the pool query command may timeout (after 5 min.). If pool query times out, we should retry. To enable the retry, set pool_query_timeout larger than 5 min, say 330 sec.
Another way that could avoid this issue is to add some sleep between nvme-faulty and pool query. We already have a variable for this in TestPool, pool_query_delay, so set some time to it in the test yaml and move the sleep code in query() to right before calling pool query.
Skip-fault-injection-test: true
Skip-func-hw-test-large: false
Test-tag: test_nvme_fault
Test-repeat: 3
Steps for the author:
After all prior steps are complete: