Skip to content

DAOS-19396 pool: mind pool_discard() dss_rpc_send() errors #18894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kccain wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Draft

DAOS-19396 pool: mind pool_discard() dss_rpc_send() errors #18894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/pool/srv_pool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7626,6 +7626,12 @@ pool_discard(crt_context_t ctx, struct pool_svc *svc, struct pool_target_addr_li
ptdi_in->ptdi_addrs.ca_count = list->pta_number;
uuid_copy(ptdi_in->ptdi_uuid, svc->ps_pool->sp_uuid);
rc = dss_rpc_send(rpc);
/* No corpc aggregation callback is registered, so ptdo_rc cannot report a send error. */
if (rc != 0) {
DL_ERROR(rc, DF_UUID ": dss_rpc_send POOL_TGT_DISCARD",
DP_UUID(svc->ps_pool->sp_uuid));
D_GOTO(decref, rc);
}

ptdi_out = crt_reply_get(rpc);
D_ASSERT(ptdi_out != NULL);
Expand All @@ -7634,6 +7640,7 @@ pool_discard(crt_context_t ctx, struct pool_svc *svc, struct pool_target_addr_li
D_ERROR(DF_UUID": pool discard failed: rc: %d\n",
DP_UUID(svc->ps_pool->sp_uuid), rc);

decref:
crt_req_decref(rpc);

out:
Expand Down
Loading