Repository navigation
feat(mcp)!: support acknowledged notification subscriptions - #34
Merged
Merged
Conversation
Add dual-era connection lifecycle, owned subscription filters and resource restoration, and fenced catalog refresh APIs. Upgrade rmcp to 3.5.1 and bundle MCP and umbrella crate 0.11.0 versions. BREAKING CHANGE: McpConnection::capabilities now returns an owned snapshot so callers observe current capabilities after authentication reconnect.
![kit-code-agent[bot]](https://avatars.githubusercontent.com/in/4797102?s=60&v=4){kind=small}
Reject partial resource replay acknowledgments before replacing the authoritative connection, and invalidate catalogs after stream recovery. Add HTTP-boundary regressions and explicit legacy/modern reference interop modes without weakening legacy session and resumption checks.
danielkov
commented
Oct 15, 2026
danielkov
enabled auto-merge (squash)
October 15, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support MCP 2026-07-28 acknowledged notification subscriptions while retaining legacy initialization and resource subscription behavior. Upgrade RMCP to 3.5.1 and bundle the
agentkit-mcpand umbrellaagentkit0.11.0 versions in this change.Motivation
Modern subscription notifications bypass RMCP's legacy client callbacks, so opening a stream alone does not update Agentkit's event or discovery surfaces. Hosts also need to fetch changed catalogs without holding a shared manager lock across network requests.
Impact
McpConnection::capabilities()now returns an owned snapshot rather than a reference, allowing callers to observe refreshed capabilities after authentication reconnect. Hosts continue to schedule catalog reconciliation explicitly; notification delivery does not automatically mutate their tool registries.Technical details
Connection-owned notification streams
Use the dual-era Auto lifecycle, wait for subscription acknowledgment, and expose requested and accepted filters through watchable status. Serialize resource filter replacements, retain the authoritative stream after rejected updates, restore committed URIs after authentication reconnect, and bound fresh-listen recovery with exponential backoff and jitter. Retiring or staging a transport fences its event delivery, and shutdown initiates transport cancellation before awaiting cleanup.
Fenced catalog publication
Add owned prepare/fetch/publish work and wake sources. Connection identity, transport epoch, notification revision, and publication generation fence obsolete results; failed or canceled work remains dirty. Batch refresh isolates server failures, and connection installation and removal publish catalog changes before asynchronous cleanup.
Dependency scope
Pin RMCP and its macros to 3.5.1, selecting process-wrap 10.0.1 transitively while preserving enabled features. The dependency audit reconciled published sources and checksums with upstream revisions; the existing advisory set is unchanged.