Warn when uploads omit unrecognized paths - #1915
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1915 +/- ##
===========================================
- Coverage 77.35% 54.30% -23.05%
===========================================
Files 89 89
Lines 13325 13443 +118
===========================================
- Hits 10307 7300 -3007
- Misses 3018 6143 +3125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Fixed the three Linux upload-test failures by placing the NWB fixture under a valid |
|
The rerun found one remaining assertion: the singular warning used “1 path were”. I fixed that in 95ac3d3 so one path reads “was” while plural counts keep “were”. Ruff checks pass; CI is running again. |
|
One macOS 3.13 job in the new matrix failed while cloning the external |
Fixes #1493
dandi uploaddiscovers only recognized assets. Before this change, a requested directory could finish with files omitted from the upload without telling the user.This adds a discovery helper that reports omitted files individually when a requested tree contains recognized assets, or collapses a wholly unrecognized directory to one entry. It keeps Dandiset metadata, dot/VCS paths, common OS metadata, empty directories, Zarr contents, and directory symlinks out of the warning. Partial uploads stay scoped to the requested paths, and
--allow-any-pathremains an explicit opt-out.The warning is registered after the progress table is created, so it is emitted after the table closes and still appears when another asset upload fails.
Tests added:
--allow-any-pathsuppression, and warning-on-upload-error behaviorLocal validation:
ruff checkandpython -m py_compilepassed