Skip to content

Add aiohttp dependency with version constraint#1872

Merged
yarikoptic merged 2 commits into
masterfrom
fix-dailies
Jun 2, 2026
Merged

Add aiohttp dependency with version constraint#1872
yarikoptic merged 2 commits into
masterfrom
fix-dailies

Conversation

@CodyCBakerPhD
Copy link
Copy Markdown
Contributor

Looks like dailies started failing just now, noticed it on #1871

This quickly patches it to get things working again; the true issue seems to be something in a nested depency (not fixable on our side)

Various errors of the form

    with ctx:
         ^^^
/opt/hostedtoolcache/Python/3.14.5/x64/lib/python3.14/site-packages/vcr/cassette.py:84: in __enter__
    return next(self.__finish)
           ^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.14.5/x64/lib/python3.14/site-packages/vcr/cassette.py:58: in _patch_generator
    for patcher in CassettePatcherBuilder(cassette).build():
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.14.5/x64/lib/python3.14/site-packages/vcr/patch.py:129: in _build_patchers_from_mock_triples
    for args in mock_triples:
                ^^^^^^^^^^^^
/opt/hostedtoolcache/Python/3.14.5/x64/lib/python3.14/site-packages/vcr/patch.py:301: in _aiohttp
    from .stubs.aiohttp_stubs import vcr_request
/opt/hostedtoolcache/Python/3.14.5/x64/lib/python3.14/site-packages/vcr/stubs/aiohttp_stubs.py:21: in <module>
    class MockStream(asyncio.StreamReader, streams.AsyncStreamReaderMixin):
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   AttributeError: module 'aiohttp.streams' has no attribute 'AsyncStreamReaderMixin'

@CodyCBakerPhD CodyCBakerPhD requested a review from yarikoptic June 2, 2026 16:37
@CodyCBakerPhD CodyCBakerPhD self-assigned this Jun 2, 2026
@CodyCBakerPhD CodyCBakerPhD added the dependencies Update one or more dependencies version label Jun 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.75%. Comparing base (80b2dc2) to head (8dcf296).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1872       +/-   ##
===========================================
+ Coverage   52.92%   76.75%   +23.83%     
===========================================
  Files          87       87               
  Lines       12788    12788               
===========================================
+ Hits         6768     9816     +3048     
+ Misses       6020     2972     -3048     
Flag Coverage Δ
unittests 76.75% <ø> (+23.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic
Copy link
Copy Markdown
Member

if this is triggered by vcr tests library, if to limit, we better just limit for the testing depends - please add versioned restriction there and point to kevin1024/vcrpy#995 issue.

Removed aiohttp dependency from the main dependencies and test sections.
@CodyCBakerPhD CodyCBakerPhD added the tests Add or improve existing tests label Jun 2, 2026
@CodyCBakerPhD
Copy link
Copy Markdown
Contributor Author

@yarikoptic Done

@CodyCBakerPhD CodyCBakerPhD moved this to Uncategorized in My Work History Jun 2, 2026
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jun 2, 2026
@yarikoptic yarikoptic merged commit d114213 into master Jun 2, 2026
77 of 78 checks passed
@github-project-automation github-project-automation Bot moved this from Uncategorized to Done in My Work History Jun 2, 2026
@yarikoptic yarikoptic deleted the fix-dailies branch June 2, 2026 20:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🚀 PR was released in 0.76.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update one or more dependencies version release Create a release when this pr is merged released tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants