Add channel profile-based sizing overrides - #108
Open
dallison wants to merge 1 commit into
Open
Conversation
Add an apply_profile option to publisher and subscriber options across the C++, C, Python, and Rust clients, allowing the server to override requested sizing values (slot size, num slots, subscriber queue size, max active messages) from a loaded channel profile. Add channel profile proto messages, resolved-sizing fields in the create responses, and the server-side profiling and profile-file handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_profileoption to publisher and subscriber options across the C++, C, Python, and Rust clients, letting the server override requested sizing (slot size, num slots, subscriber queue size, max active messages) from a loaded channel profile. Whenapply_profileis false, the requested values are authoritative.ChannelProfileObservation,ChannelProfileRecommendation,ChannelProfile,ChannelProfileFile) and resolved-sizing fields in the create publisher/subscriber responses.Test plan
bazelisk test //...apply_profiledefaults and toggling in the C++, C, Python, and Rust client tests