fix(memory): compare resolved paths in the delete root guard - #2
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
When message_start event omits the usage field, the usage is never initialized. This causes errors later when message_delta tries to access current_snapshot.usage.output_tokens. This fix ensures usage is initialized with default values (input_tokens=0, output_tokens=0) when message_start omits it.
The delete guard was comparing raw command.path against "/memories", but _validate_path already normalizes and resolves the path. This allowed variations like /memories/, /memories//, /memories/. to slip past the guard. Fix by comparing the resolved full_path against memory_root.resolve() instead of comparing raw command.path against "/memories". This fixes both the sync and async delete methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for anthropics#1906 - compare resolved paths instead of raw command.path to prevent path bypass in delete root guard