Conversation
Contributor
|
Sorry for the delay, works as intended when I tested it locally, looks good to me, I'll try reworking a non invasive way for selecting text in individual search results as suggested. |
Owner
Author
|
No worries. I've also been super busy lately so I apologize for the delay getting back to you on your PRs. And I agree that selectable text is desirable, but not at the cost of complexity or performance. I wish there was a simple flag that could be enabled via Qt but it seems not 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC: @saberoueslati
This obviously doesn't make it selectable. I would still be open to that if there's a light-weight and non-invasive way to do it. Notepad++ collects all its search results in another text editor that it highly controls so it gives a bit more 'text-like' capabilities.
The other thing was in #1072 was the MainWindow.cpp changes. This is a problem...but I think the issue is larger than a specific check. In theory any
QDockWidgetshould be able to add their own shortcuts (e.g. Lua Console, Debug Log, etc) and not require the main window to know about what shortcuts it needs.