feat: redact GCS error messages in HTTP responses - #67
Open
kaiburjack wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, whenever GCS responds with 404 due to an object in a bucket not existing, the full GCS bucket/object path is mentioned in the response.
This has security implications for gcsproxy deployments that are being served publicly, like we do behind a CDN. These information can be used by malicious actors to enumerate buckets and objects within buckets and access permissions of the GCS service account against those buckets.
In our own gcsproxy fork redact all information from the 404 and 500 response bodies to not reveal these information. There is still an option to log the errors, though, to see whether anything suspicious is going on.
This PR adds a flag to redact error bodies from responses and to toggle logging of such error messages.