Skip to content

fix(updater): n-port name key from the shared template 3380d91 - #90

Merged
daggerok merged 1 commit into
mainfrom
fix/nport-name-key
Oct 26, 2026
Merged

daggerok merged 1 commit into
mainfrom
fix/nport-name-key

Conversation

@daggerok

@daggerok daggerok commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • Re-applied the shared nport-reader block from workspace template commit 3380d91 (this repo carried 5999634 since fix(updater): current shared n-port name key (dotted legal abbreviations, public limited company) #89): nportNameKey now joins every run of single-letter initials whether written with dots, spaces or a slash (N.V. = N V = NV, C.H. ROBINSON = SEC's C H ROBINSON, A/S = A S), keeps a leading US (U.S. BANCORP is no longer Bancorp, Inc. = TBBK) and strips backslash EDGAR suffixes (US BANCORP \DE\) as well as the slash ones; PUBLIC LIMITED COMPANY stays plc
  • New test N-PORT issuer names match SEC titles across initials, a leading US and backslash EDGAR suffixes in parsing 3 (US Bancorp -> USB, Bancorp Inc/The -> TBBK, CH Robinson Worldwide Inc -> CHRW); it fails with the 5999634 block
  • Only the N-PORT ticker match by issuer name changes; the other blocks are identical

Why

Issuer names in N-PORT filings and SEC company titles spell initials differently, so U.S. equities could lose their ticker or (U.S. Bancorp) get a wrong one

Effect on real filings

Newest real N-PORT-P filing read with this repo's own readNportHoldings + nportTickers (published rows 0, as with the fund folder removed), old block vs new block on byte-identical cached SEC answers; nothing written to api/:

DGRW (2026-06-30, 198 positions): tickers 197 -> 197, 0 changed
DLN (2026-06-30, 312 positions): tickers 308 -> 308, 0 changed
DES (2026-06-30, 525 positions): tickers 519 -> 519, 0 changed
EPS (2026-06-30, 506 positions): tickers 473 -> 473, 0 changed

No ticker changes for these funds today (the filer gives most tickers itself; in EPS the 33 rows without one are non-U.S. ISINs and money market funds); the change guards future filings

Checks

  • bun test: 66 pass, 0 fail, exit 0 (one new test); the same with every update-data.config.json control exported: 66 pass, exit 0
  • bun build --target=bun scripts/update-data.ts --outfile=/dev/null, bun build --target=bun src/main.tsx --outfile=/dev/null, git diff --check
  • check-readme.ts ., check-scripts.ts .: ok; apply-block.ts --check holdings-guard,nport-reader,windowed-chart,fund-selection .: all identical
  • tc/check.sh .: no new errors (52 lines, same as main)

@daggerok
daggerok merged commit b70db8a into main Oct 26, 2026
1 check passed
@daggerok
daggerok deleted the fix/nport-name-key branch October 26, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant