Drop the polyfill for the engine's findConfigDirs - #2
Closed
grouville wants to merge 2 commits into
Closed
Conversation
The engine now ships Workspace.findConfigDirs (dagger/dagger#13769): the same cwd-aware project discovery this module got from github.com/dagger/polyfill — same semantics, ported from the polyfill's own design and test matrix. Swap the call, drop the dependency, and require the engine release that ships it. This module was still pinned to v0.20.6 and used the legacy Workspace.path field, which the v1 view removed — so the version bump also ports the relative-path helper onto Workspace.cwd, the v1 spelling of the same value. The engineVersion bump and the dependency removal have to land together: the version gate is what keeps the engine's new changeset behavior scoped to migrated modules. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker module uses
dagger/polyfillto find Dockerfile and Compose projects around the directory where Dagger was started. The nativeWorkspace.findConfigDirsAPI in dagger/dagger#13854 preserves that behavior: projects below the current directory are included, or the nearest enclosing project is selected when running inside one.That discovery replacement is the purpose of this PR. It also updates the stale local
./proxydependency to the workspace'sdagger/proxymodule so the repository can regenerate cleanly.No Docker build or Compose behavior is intended to change. Reviewers only need to check the discovery call, the proxy reference, and the generated diff.
Test
dagger checkThe repository check passes against the development engine. The provisional engine version will be updated when #13854 is released.