d2lib: preserve theme override precedence - #2832
Merged
Merged
Conversation
alixander
force-pushed
the
agent/fix-theme-override-precedence
branch
5 times, most recently
from
August 10, 2026 01:28
88f47ed to
2a78c0f
Compare
Signed-off-by: Alexander Wang <alex@terrastruct.com>
alixander
force-pushed
the
agent/fix-theme-override-precedence
branch
from
August 10, 2026 01:28
2a78c0f to
5639a66
Compare
alixander
marked this pull request as ready for review
August 10, 2026 01:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Apply source-defined light and dark theme overrides only when the caller did not already provide the corresponding render option.
Why
applyConfigsdocuments that caller-supplied options take precedence and follows that rule for layout, theme IDs, sketch, padding, and centering. Theme override objects were the exception: they were assigned unconditionally, so source configuration silently replaced public Go API options.Validation
go test ./d2lib -count=1go test -race ./d2lib -run '^TestApplyConfigsThemeOverridePrecedence$' -count=1go test ./e2etests -run '^TestE2E$' -count=1 -parallel=1git diff --check