Skip to content

feat(ux): add aria-describedby to keyboard shortcuts modal #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-oit wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ux): add aria-describedby to keyboard shortcuts modal #600

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
830532b
feat(ux): add aria-describedby to keyboard shortcuts modal
google-labs-jules[bot] Aug 28, 2026
460bbf7
feat(ux): add aria-describedby to keyboard shortcuts modal
google-labs-jules[bot] Aug 28, 2026
e3e15e0
feat(ux): add aria-describedby to keyboard shortcuts modal
google-labs-jules[bot] Aug 28, 2026
4572226
feat(ux): add aria-describedby to keyboard shortcuts modal
google-labs-jules[bot] Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/app/components/KeyboardShortcutsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export function KeyboardShortcutsModal({ onClose }: KeyboardShortcutsModalProps)
role="dialog"
aria-modal="true"
aria-labelledby="shortcuts-modal-title"
aria-describedby="shortcuts-modal-description"
>
<div className="flex justify-between mb-4">
<h2 id="shortcuts-modal-title" className="text-[13px] font-bold text-foreground">
Expand All @@ -112,7 +113,7 @@ export function KeyboardShortcutsModal({ onClose }: KeyboardShortcutsModalProps)
×
</button>
</div>
<div className="space-y-2">
<div id="shortcuts-modal-description" className="space-y-2">
{SHORTCUTS.map(({ key, action }) => (
<div key={key} className="flex justify-between text-[11px]">
<span className="text-text-muted">{action}</span>
Expand Down
Loading