Backport upstream logging#186
Open
arctic-alpaca wants to merge 5 commits into
Open
Conversation
This reverts commit f795caf. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
Add support for formatting logs following the popular glog crate style. In particular this can use local or UTC time along with a single character level. As an implementation detail of that implement finegrained date time log outputs including both local and UTC variants. Signed-off-by: Rob Bradford <rbradford@meta.com> Assisted-by: Claude:Opus-4.6 (cherry picked from commit e0c68db)
Local-time log fields called `jiff::Zoned::now()`, which resolves the system timezone on every record by reading `/etc/localtime`/`/etc/timezone` if it doesn't hit the cached version. This cache miss could then cause a seccomp violation depending on the thread it was run from. Avoid this by capturing the value in `Logger`. This avoids opening the seccomp filter for the whole process. Signed-off-by: Dylan Reid <dgreid@fb.com> (cherry picked from commit b88d5de)
This reverts commit 3caabf4. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
Co-authored-by: Philipp Schuster <philipp.schuster@cyberus-technology.de> On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
arctic-alpaca
marked this pull request as ready for review
July 24, 2026 08:58
hertrste
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts our fork-local commits for parity with upstream, then reintroduces our custom version print on startup.
Relates to https://github.com/cobaltcore-dev/cobaltcore/issues/557
Relates to https://github.com/cobaltcore-dev/cobaltcore/issues/639
Libvirt PR: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/264