vmm: add resize permission to qemu-compatible locking#185
Open
arctic-alpaca wants to merge 1 commit into
Open
Conversation
Also lock the resize permission lock for read-write opened disks. Cloud-hypervisor can resize disks, so we should lock the byte. On-behalf-of: SAP julian.schindel@sap.com Signed-off-by: Julian Schindel <julian.schindel@cyberus-technology.de>
arctic-alpaca
force-pushed
the
qemu-resize
branch
from
July 23, 2026 14:17
bf2f494 to
af2e577
Compare
arctic-alpaca
marked this pull request as ready for review
July 23, 2026 15:00
Coffeeri
approved these changes
Jul 24, 2026
Coffeeri
left a comment
Coffeeri
left a comment
There was a problem hiding this comment.
Looks good, thank you for adding it!
amphi
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also lock the resize permission lock for read-write opened disks. Cloud-hypervisor can resize disks, so we should lock the byte.
Fixes https://github.com/cobaltcore-dev/cobaltcore/issues/627
Libvirt: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/263
Before merging, this should be tested on customer infra.