Repository navigation
[*] infer Prometheus presets in TestDefaultPresetsReferenceDefinedMetrics - #1604
Merged
Merged
Conversation
Coverage Report for CI Build 38800400935Coverage remained the same at 87.853%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
0xgouda
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test from #1568 skipped
patroniandpostgres-exporter-basicby name, so every new Prometheus preset would fail it until someone extended the list.Nothing in the preset data marks a preset as Prometheus-only, and adding a field would need a config schema migration. The test now infers it instead: a preset whose metrics are all undefined lists exporter metric families and is skipped. A preset with some undefined metrics, which is how the
aiven/index_col_statsbug looked, still fails.Verified by re-adding
index_col_statsto SQL presets: the test fails and names them.