Skip to content

[-] fix finished timestamp in execution log, closes #788 - #791

Merged
pashagolub merged 3 commits into
masterfrom
788-fix-finished-ts
Jul 17, 2026
Merged

[-] fix finished timestamp in execution log, closes #788#791
pashagolub merged 3 commits into
masterfrom
788-fix-finished-ts

Conversation

@pashagolub

Copy link
Copy Markdown
Collaborator

No description provided.

@pashagolub pashagolub self-assigned this Jul 13, 2026
@pashagolub pashagolub added the bug Something isn't working label Jul 13, 2026
@pashagolub
pashagolub requested a review from 0xgouda July 13, 2026 19:42
@coveralls

coveralls commented Jul 13, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29608169153

Coverage increased (+0.1%) to 89.961%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 4 of 4 lines across 4 files are fully covered (100%).
  • 3 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
internal/scheduler/chain.go 3 89.15%

Coverage Stats

Coverage Status
Relevant Lines: 2291
Covered Lines: 2061
Line Coverage: 89.96%
Coverage Strength: 1.02 hits per line

💛 - Coveralls

@robe2

robe2 commented Jul 16, 2026

Copy link
Copy Markdown

Tested this and confirm it's working now: Here is previous run before I recompiled with patch and then after the patch from my pgAdmin pgTimeTable UI work in progress

image

pashagolub and others added 3 commits July 17, 2026 21:36
Co-authored-by: 0xgouda <gouda0x@gmail.com>
Cover the empty params and multiple params code paths in the
tests checking `task.StartedAt` value, not only the multiple params
scenario.
@pashagolub
pashagolub force-pushed the 788-fix-finished-ts branch from c775c5f to 1ccace6 Compare July 17, 2026 19:36
@pashagolub
pashagolub merged commit 331a894 into master Jul 17, 2026
7 checks passed
@pashagolub
pashagolub deleted the 788-fix-finished-ts branch July 17, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants