Repository navigation
Say that every workflow a slot reaches needs a concurrency group - #7
Merged
Merged
Conversation
The README stated the rule only for a workflow running the slot action. It told a reconciler that declaring the dispatch type was the whole enrollment, because running it twice is harmless; running it twice at once is not, and enrolling makes that likely, since the clock's dispatch and GitHub's schedule run of one slot can start minutes apart. A chained workflow was told to use the slot action unchanged, with nothing saying the parent's group does not cover its own runs. The rule now has one section covering all three: which queue each needs and why, and the pull-request keying that was under the enrolling example. The reconciler example declares its group, and the slot action's header names chained workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README stated the concurrency rule only for a workflow running the slot action.
schedulerun of one slot can start minutes apart.Changes:
queue: max; reconcilers are fine on the default queue. The pull-request keying example moves there from the enrolling section.slot/action.yml's header now says chained workflows must serialize too.Docs and comments only. Nothing ships differently, so no release or tag move is needed.