docs: document country name matching in region maps - #11421
Conversation
|
Claude finished @igorlukanin's task in 1m 38s —— View job Review complete — docs-only change, no blockers. 3 findings: 2 medium, 1 low (all inline).Full review
ScopeProse-only addition of one H3 section to an existing page in What's good
Findings
Details and suggested edits are in the inline comments. Minor notes (not worth inline threads)
What I could not verifyThe behavior being documented lives in the frontend/chart implementation, which isn't in this repo — I did not run the Mintlify dev server or a linter — this is a prose-only |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 46s —— View job Re-review after
|
| # | Prior issue | Status |
|---|---|---|
| 1 | Para 1 vs para 2 contradiction on US |
✅ Fixed — US dropped from the interchangeable list at map.mdx:74; para 2 (map.mdx:76) now introduces it as "Bare 2-letter codes such as US…". The two paragraphs no longer disagree. |
| 2 | H3 inserted above the choropleth-gradient paragraph | ✅ Fixed — the palette sentence is back in the Region map H2 intro at map.mdx:70, with ### Country name matching starting at map.mdx:72. |
| 3 | colouring British spelling |
✅ Fixed — now coloring at map.mdx:76. |
Bonus: the Alpha-3 gap I flagged as an aside is closed too — map.mdx:62 now lists ISO3166-1-Alpha-3 alongside ISO3166-1-Alpha-2, so the Property list and the "2- and 3-letter ISO code properties" claim at map.mdx:74 line up. The author confirmed the World countries source exposes both.
Thread housekeeping
All three of my threads were already resolved (GitHub marked them outdated once the lines moved) — nothing left to resolve, and no duplicate inline comments to skip.
New issues
None. The rewrite is a clean subtraction plus a move — no new claims were introduced, and the sentence flow reads correctly with US deferred to the second paragraph. Section structure is now: H2 intro (requirements list → allowed-properties note → auto-pick → palette) → ### Country name matching → ### Custom GeoJSON, which is consistent with how Point map is broken up earlier on the page.
Standing caveat (unchanged)
The matching behavior itself lives outside this repo, so I still can't verify the claims against the implementation — reverse matching (name in data, code as Property) in particular. The author's confirmation on Alpha-3 covers the one piece I could point at concretely. This is a prose-only .mdx change with no components, links, or frontmatter touched, so the code-review axes in the review config (security, performance, error handling, test coverage) don't apply; the Mintlify preview build is the relevant check and it's green.
• Branch •
Summary
Region maps join a query dimension to the boundary data by name or ISO code, and the World Countries boundaries use long-form names — so
United Statesin a user's data did not match theUnited States of Americapolygon. That join is now tolerant of alternate spellings, and this documents the behavior.Added a Country name matching section under Region map covering what resolves (long forms, endonyms, abbreviations, both ISO code properties, in either direction), the two guarantees worth knowing — matching is exact rather than approximate, and bare 2-letter codes only count as country codes when Property is set to an ISO code property — and that this applies to World countries only, not US states or Custom.
Test plan