Repository navigation
Enforce Csound 7.0 minimum version in FindCSOUND - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The 7.x codebase is being built against Csound 6.x installations because
FindCSOUND.cmakenever checked the installed Csound version.Changes:
cmake/Modules/FindCSOUND.cmake: parseCS_VERSION/CS_SUBVER/CS_PATCHLEVELfromversion.hintoCSOUND_VERSIONand pass it tofind_package_handle_standard_argsviaVERSION_VAR, so version requirements are enforced.CMakeLists.txt: requestfind_package(CSOUND 7.0)and fail with a clear message if the found version is < 7.0.Verification: tested against a local Csound 6.18.1 install (
CSOUND_FOUND=FALSE) and a 7.0.0 install (CSOUND_FOUND=TRUE).