fix: avoid crash opening large text files in built-in editor - #655
Open
xhon-pelushi wants to merge 2 commits into
Open
fix: avoid crash opening large text files in built-in editor#655xhon-pelushi wants to merge 2 commits into
xhon-pelushi wants to merge 2 commits into
Conversation
BrowseFilesPresenter.viewFile() routed .txt/.md/.todo files to the built-in text editor with no size check. TextEditorPresenter reads the whole file into a String for the EditText, so memory use scales with file size; a ~15 MB file kills the process and locks all vaults. Skip the internal editor for files above 2 MiB and fall back to opening them with an external app instead, matching the existing behavior for other unsupported file types. Fixes cryptomator#654
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent OutOfMemory/crash when opening large text files in the built-in editor.
Fixes #654
Test plan