Repository navigation
Conversation
haarchri
requested review from
a team,
jcogilvie and
tampakrap
as code owners
November 18, 2026 13:52
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
5 tasks done
Add HTTP CONNECT proxying (including SSH tunneling via CONNECT) and opt-in SSH host key verification skipping for git-based dependencies, with per-transport default auth providers (SSH agent for SSH URLs, anonymous HTTPS otherwise). Exposed as --git-proxy and --git-insecure-host-key on dependency add, dependency update-cache, and project build. Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
haarchri
force-pushed
the
feat/git-proxy-ssh-support
branch
from
November 18, 2026 14:06
b787616 to
6cd39d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Git-based crd dependencies currently support only direct HTTPS with optional username/token auth. This PR adds:
Fixes #
I have:
./nix.sh flake checkto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.
Validation
Unit tests for the proxy dialer (CONNECT handshake, auth, context cancellation), URL classification/username extraction, and provider selection; proxy settings apply to both clones and the SHA-checkout fetch path.