Repository navigation
Conversation
The zero metadata.creationTimestamp marshals as an explicit null, so every dependency add or composition generate rewrote the project file with a creationTimestamp: null line. Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
The import statements were built by ranging over a map, so the order of imports in a generated function's main.k varied between runs. Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
function-kcl v0.12.1 returns duplicate composed resources when the composition function is invoked with observed resources, failing with 'multiple composed resources with name ... returned'. v0.12.3 behaves correctly. Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
update-cache regenerated schemas for dependencies but not for the project's own APIs, which were only generated during build. Language tooling that imports the project's XRD models (functions, tests, editors) therefore saw incomplete models after update-cache - e.g. go mod tidy in an embedded function failed before the first build. Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
haarchri
requested review from
a team,
jcogilvie and
tampakrap
as code owners
November 18, 2026 13:50
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Four small, independent fixes in the project tooling:
Fixes #
I have:
./nix.sh flake checkto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.
Validation
Unit tests for the import ordering and project file writing; the function-kcl and update-cache changes verified end-to-end against a project with an XRD and an embedded KCL function (render with observed resources, go mod tidy after update-cache alone).