Skip to content

fix(attr): serialize installation of attributes.h to avoid race conditions - #1291

Merged
crazywhalecc merged 2 commits into
v3from
fix/attr
Nov 16, 2026
Merged

crazywhalecc merged 2 commits into
v3from
fix/attr

Conversation

@crazywhalecc

@crazywhalecc crazywhalecc commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

What does this PR do?

https://github.com/static-php/hosted/actions/runs/43694610580/job/132752307737#step:10:113759

Checklist before merging

  • If you modified *.php or *.yml, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:lint-config

@crazywhalecc crazywhalecc added bug Something isn't working need-test This PR has not been tested yet, cannot merge now labels Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

StaticPHP Test Bot

Detected: Extensions: none | Libraries: attr, libacl | Targets: none
Active labels: none
Available labels: need-test (gate), test/linux test/windows test/macos (platform), test/tier2 (extra arch), test/php-83 test/php-84 (PHP version), sapi/frankenphp (extra FrankenPHP SAPI build)
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

@henderkes

Copy link
Copy Markdown
Collaborator

Also need to do the same for libacl.

@henderkes

Copy link
Copy Markdown
Collaborator

@copilot set concurrency to 1 for libacl's install command too, just like in this branch

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

@copilot set concurrency to 1 for libacl's install command too, just like in this branch

Set libacl's install command to concurrency 1 in commit e0a24be.

Copilot AI requested a review from henderkes November 15, 2026 15:46
@crazywhalecc
crazywhalecc merged commit 565e5eb into v3 Nov 16, 2026
7 checks passed
@crazywhalecc
crazywhalecc deleted the fix/attr branch November 16, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working need-test This PR has not been tested yet, cannot merge now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants