Skip to content

fix: enhance compatibility with GmSSL and improve C++ runtime linking - #1286

Merged
crazywhalecc merged 1 commit into
v3from
fix/ext-matrix-static-links
Nov 9, 2026
Merged

crazywhalecc merged 1 commit into
v3from
fix/ext-matrix-static-links

Conversation

@crazywhalecc

Copy link
Copy Markdown
Owner

What does this PR do?

Fix static-php/hosted weekly matrix tests.

Checklist before merging

  • If you modified *.php or *.yml, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:lint-config

@crazywhalecc crazywhalecc added need-test This PR has not been tested yet, cannot merge now test/tier2 Trigger Tier 2 environment build test labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

StaticPHP Test Bot

Detected: Extensions: gmssl, openssl | Libraries: librdkafka | Targets: none
Active labels: test/tier2
Available labels: need-test (gate), test/linux test/windows test/macos (platform), test/tier2 (extra arch), test/php-83 test/php-84 (PHP version), sapi/frankenphp (extra FrankenPHP SAPI build)
Config: Linux x86_64 + Windows x86_64 + macOS arm64 + Linux aarch64 (Tier2) + macOS x86_64 (Tier2) | PHP 8.5 NTS

$args = '--with-openssl=' . ($shared ? 'shared,' : '') . BUILD_ROOT_PATH . $openssl_dir;
if (php::getPHPVersionID() >= 80500 || (php::getPHPVersionID() >= 80400 && !$builder->getOption('enable-zts'))) {
$args .= ' --with-openssl-argon2 OPENSSL_LIBS="-lz"';
$args .= ' --with-openssl-argon2 OPENSSL_LIBS="-lssl -lcrypto -lz"';

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit surprised but no objection

@crazywhalecc
crazywhalecc merged commit ff04d4a into v3 Nov 9, 2026
24 of 31 checks passed
@crazywhalecc
crazywhalecc deleted the fix/ext-matrix-static-links branch November 9, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-test This PR has not been tested yet, cannot merge now test/tier2 Trigger Tier 2 environment build test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants