Skip to content

fix(ffi): don't enable Zend signals - #1283

Merged
crazywhalecc merged 4 commits into
crazywhalecc:v3from
tina-junold:fix/ffi-zend-signals
Nov 5, 2026
Merged

crazywhalecc merged 4 commits into
crazywhalecc:v3from
tina-junold:fix/ffi-zend-signals

Conversation

@tina-junold

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes --enable-zend-signals from the ffi configure args. It overrides --disable-zend-signals in ZTS builds, and FrankenPHP won't start with Zend signals enabled. ext/ffi doesn't use ZEND_SIGNALS.

Fixes #1282. Details and test results are in the issue: glibc FrankenPHP build with ctype,ffi, the server starts and FFI::cdef() works in normal and worker mode.

The same flag is in src/SPC/builder/extension/ffi.php on main (v2). Happy to send a separate PR for that if wanted.

Checklist before merging

Only config/pkg/ext/builtin-extensions.yml changed, no *.php or *.json.

🤖 Generated with Claude Code

ext-ffi doesn't use ZEND_SIGNALS. Passing --enable-zend-signals
overrides --disable-zend-signals for ZTS builds, and FrankenPHP
refuses to start with Zend signals enabled.

Fixes crazywhalecc#1282

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread config/pkg/ext/builtin-extensions.yml Resolved
Comment thread config/pkg/ext/builtin-extensions.yml Resolved
Comment thread config/pkg/ext/builtin-extensions.yml Resolved
@crazywhalecc
crazywhalecc merged commit 5e91337 into crazywhalecc:v3 Nov 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ext-ffi enables Zend signals, FrankenPHP then refuses to start

3 participants