Repository navigation
fix(ffi): don't enable Zend signals - #1283
Merged
Merged
Conversation
ext-ffi doesn't use ZEND_SIGNALS. Passing --enable-zend-signals overrides --disable-zend-signals for ZTS builds, and FrankenPHP refuses to start with Zend signals enabled. Fixes crazywhalecc#1282 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
henderkes
requested changes
Nov 5, 2026
henderkes
reviewed
Nov 5, 2026
henderkes
approved these changes
Nov 5, 2026
henderkes
reviewed
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
--enable-zend-signalsfrom the ffi configure args. It overrides--disable-zend-signalsin ZTS builds, and FrankenPHP won't start with Zend signals enabled.ext/ffidoesn't useZEND_SIGNALS.Fixes #1282. Details and test results are in the issue: glibc FrankenPHP build with
ctype,ffi, the server starts andFFI::cdef()works in normal and worker mode.The same flag is in
src/SPC/builder/extension/ffi.phponmain(v2). Happy to send a separate PR for that if wanted.Checklist before merging
Only
config/pkg/ext/builtin-extensions.ymlchanged, no*.phpor*.json.🤖 Generated with Claude Code