Skip to content

fix(frankenphp): point pkg-config at the buildroot on Windows - #1281

Merged
henderkes merged 1 commit into
crazywhalecc:v3from
m-this:mfe/fix/frankenphp-windows-brotli
Nov 2, 2026
Merged

henderkes merged 1 commit into
crazywhalecc:v3from
m-this:mfe/fix/frankenphp-windows-brotli

Conversation

@m-this

@m-this m-this commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The FrankenPHP build on Windows fails as soon as brotli is resolved. caddy-cbrotli finds it through #cgo pkg-config, the .pc files are in buildroot/lib/pkgconfig, but buildFrankenphpForWindows() never sets PKG_CONFIG_PATH, so cgo stops at Package libbrotlicommon was not found. This sets it with the other cgo variables.

  • Same failure on unmodified v3.
  • Build with this change on windows-latest with PHP 8.5: frankenphp.exe runs and http.encoders.br is in list-modules.
  • Same build on top of #1280, which removes the -mthreads shim: same result.
  • pkg-config in those runs comes from the runner image (C:\Strawberry\perl\bin). spc's own strawberry-perl only reaches PATH if it was installed before the build started, so a clean Windows machine without one still fails. Not handled here.

Checklist before merging

  • composer cs-fix
  • composer analyse
  • composer test
  • bin/spc dev:lint-config

- caddy-cbrotli pulls brotli through `#cgo pkg-config`, and the Windows go build never set PKG_CONFIG_PATH
- so a build that resolves brotli stops at `Package libbrotlicommon was not found`
@henderkes
henderkes merged commit 7680647 into crazywhalecc:v3 Nov 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants