Repository navigation
fix(curl): enhance Windows TLS backend support and update documentation - #1277
Merged
Merged
Conversation
henderkes
reviewed
Nov 1, 2026
henderkes
left a comment
Collaborator
There was a problem hiding this comment.
I'd rather avoid this extra logic if using openssl is possible, which it should be.
|
StaticPHP Test Bot Detected: Extensions: |
…check
The upstream config.m4 probes libssl with
PHP_CHECK_LIBRARY(ssl, SSL_CTX_new) without naming the libraries libssl.a
itself depends on, so the conftest fails with undefined libcrypto symbols
in static builds and configure aborts with:
configure: error: --enable-clickhouse-openssl requires libssl, ...
Any build that resolves the openssl library (for example an extension
batch that also contains curl, or --with-suggests) enables
--enable-clickhouse-openssl in the package hook, so this broke the Linux
and macOS ext test matrices.
Preload libcrypto/libz into LIBS right before that check. Verified with a
static macOS build: "checking for SSL_CTX_new in -lssl... yes", the build
completes and the resulting php loads the clickhouse extension.
henderkes
reviewed
Nov 2, 2026
henderkes
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Close #1249
Checklist before merging
*.phpor*.yml, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:lint-config