Skip to content

fix(curl): enhance Windows TLS backend support and update documentation - #1277

Merged
crazywhalecc merged 4 commits into
v3from
v3c/win-curl-tls-backend
Nov 2, 2026
Merged

crazywhalecc merged 4 commits into
v3from
v3c/win-curl-tls-backend

Conversation

@crazywhalecc

Copy link
Copy Markdown
Owner

What does this PR do?

Close #1249

Checklist before merging

  • If you modified *.php or *.yml, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:lint-config

@henderkes henderkes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather avoid this extra logic if using openssl is possible, which it should be.

Comment thread config/env.ini Resolved
@crazywhalecc crazywhalecc added need-test This PR has not been tested yet, cannot merge now os/windows Things only for Windows labels Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

StaticPHP Test Bot

Detected: Extensions: clickhouse, curl | Libraries: none | Targets: curl
Active labels: none
Available labels: need-test (gate), test/linux test/windows test/macos (platform), test/tier2 (extra arch), test/php-83 test/php-84 (PHP version), sapi/frankenphp (extra FrankenPHP SAPI build)
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

…check

The upstream config.m4 probes libssl with
PHP_CHECK_LIBRARY(ssl, SSL_CTX_new) without naming the libraries libssl.a
itself depends on, so the conftest fails with undefined libcrypto symbols
in static builds and configure aborts with:

    configure: error: --enable-clickhouse-openssl requires libssl, ...

Any build that resolves the openssl library (for example an extension
batch that also contains curl, or --with-suggests) enables
--enable-clickhouse-openssl in the package hook, so this broke the Linux
and macOS ext test matrices.

Preload libcrypto/libz into LIBS right before that check. Verified with a
static macOS build: "checking for SSL_CTX_new in -lssl... yes", the build
completes and the resulting php loads the clickhouse extension.
Comment thread config/env.ini Resolved
@crazywhalecc
crazywhalecc merged commit 1a87849 into v3 Nov 2, 2026
11 checks passed
@crazywhalecc
crazywhalecc deleted the v3c/win-curl-tls-backend branch November 2, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-test This PR has not been tested yet, cannot merge now os/windows Things only for Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the Windows curl TLS backend selectable — Schannel blocks PEM client certificates

2 participants