[5.x] Fix Variant Search product condition rule returning no results#4341
Open
lukeholder wants to merge 2 commits into
Open
[5.x] Fix Variant Search product condition rule returning no results#4341lukeholder wants to merge 2 commits into
lukeholder wants to merge 2 commits into
Conversation
The rule feeds its value into ElementQuery::search(), but it was using paramValue() from BaseTextConditionRule, which prepends the operator (e.g. "= ") intended for Db::parseParam(). That prefix corrupted the search query, so it matched nothing when used by a custom source (or filter). Use the raw trimmed value instead. Fixes #4339
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Commerce “Variant Search” product condition rule so it passes the raw search string into ElementQuery::search() (rather than the operator-prefixed paramValue() format intended for Db::parseParam()), restoring expected results when used via custom sources/criteria.
Changes:
- Introduced a raw
searchValue()accessor and used it for variantsearch()calls in bothmodifyQuery()andmatchElement(). - Added an Unreleased changelog entry referencing issue #4339.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/elements/conditions/products/ProductVariantSearchConditionRule.php | Stops using operator-prefixed paramValue() for search queries by switching to a raw trimmed value. |
| CHANGELOG.md | Documents the fix under an Unreleased entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $variantQuery = Variant::find(); | ||
| $variantQuery->select(['commerce_variants.primaryOwnerId as id']); | ||
| $variantQuery->search($this->paramValue()); | ||
| $variantQuery->search($this->searchValue()); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule feeds its value into ElementQuery::search(), but it was using paramValue() from BaseTextConditionRule, which prepends the operator (e.g. "= ") intended for Db::parseParam(). That prefix corrupted the search query, so it matched nothing when used by a custom source (or filter).
Related issues
#4339