[5.x] Conditionally add purchasable to line item’s extra fields, to prevent exceptions on to array#4340
Merged
nfourtythree merged 5 commits intoJul 21, 2026
Conversation
…nt exceptions on to array
lukeholder
self-requested a review
July 20, 2026 10:11
lukeholder
approved these changes
Jul 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an InvalidConfigException thrown when serializing custom LineItem instances by avoiding expansion of the purchasable extra field when the line item type is not purchasable (related to #4337).
Changes:
- Make
extraFields()includepurchasableonly forLineItemType::Purchasableline items. - Filter out the conditional
nullentry from the extra fields list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nfourtythree
deleted the
nathaniel/com-592-5x-invalidconfigexception-when-calling-toarray-on-custom
branch
July 21, 2026 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#4337