-
Notifications
You must be signed in to change notification settings - Fork 0
[3.x] Add edge image editor saves #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timkelty
wants to merge
11
commits into
3.x
Choose a base branch
from
timkelty/cloud-image-editor-edge-save
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e7a90f8
Add edge image editor saves
timkelty 199ea99
Address image editor review feedback
timkelty 09295a0
Fall back for unsupported image editor rotations
timkelty 6487a67
Address image editor validation feedback
timkelty d6ad129
Handle zoom-only image editor changes
timkelty e8c39b9
Validate image editor edge crops
timkelty a023294
Fallback for non-exact image rotations
timkelty f4dc7f7
Address image editor fallback feedback
timkelty b1601a9
Tighten image editor fallback handling
timkelty 93ec7ff
Move image editor transforms to editor
timkelty e42ad39
Handle image editor transfer failures
timkelty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this constraint, the Craft 4.6–4.18.1 projects advertised as supported in
README.md:18can no longer resolve or install this extension. Update the installation/support documentation to state the new 4.18.2 minimum so users do not encounter an unexpected Composer conflict.Useful? React with 👍 / 👎.