Repository navigation
Add RPC HTTP messages and local Sandbox previews - #127
Merged
Merged
Conversation
forhappy
changed the title
forhappy
marked this pull request as ready for review
October 26, 2026 15:24
Run the published preview helper against the pinned image. Add bounded port declarations for hosts that need Docker publication, and supply the Workers rejection events and native token comparison required by the SDK.
forhappy
changed the title
Keep runtime failures distinct from requested shutdown after the V8 merge. Check SQLite authorizer installation before testing reserved-table refusal. Record the selected delivery evidence and remaining callback/alarm gap.
A pending alarm must yield while native callback admission is held, so the language thread can finish that callback. Use the async bridge for async alarm APIs and restore the original overlapping-barrier image probe. Native gates and existing deadlines remain intact. Record the separately reproduced first-call timeout without claiming complete module or provider qualification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Node Workers HTTP-message RPC and runs the published Sandbox 0.12.9 HTTP preview helper on Cellar’s native containers.
exposed_portsfor image-independent TCP publication, with loopback/daemon-assigned bindings and acontainer-ports-v1deployment gate.crypto.subtle.timingSafeEqual; ordinary Node fatal rejection behavior remains unchanged.Validation: the merged-main baseline passed 750 selected Rust tests and four exact-image scenarios. After the alarm fix, 88 JS/tool/type checks, all 16 Workers tests, three module tests and all four pinned-image scenarios pass. Strict adapter all-target, affected core/container/package, and independent Node-only/V8-only Clippy pass. Rust/JS formatting, layout, docs and the native-only dependency guard pass.
Qualification remains partial: the complete module target currently has an intermittent first
/alice/counttimeout at its existing 250 ms handler budget. This also reproduces with the prior alarm implementation restored; a passing instrumented run does not resolve its cause. Initial V8 authority/first-request timeouts pass in isolation and on the Workers repeat but remain recorded as intermittent. No assertions or budgets were weakened.Next priorities are first-call latency, callback-owned queued controls, remaining hooks and upgraded Worker/DO routing, followed by named durable provider reconnect/expiry/orphan cleanup and independently qualified Sandbox 1.x/additional providers. E2B/Vercel real-account qualification awaits configuration. The delivery plan and implementation ledger record exact evidence and remaining requirements.