test: no-ticket: Improve coverage of rowsets. - #226
Draft
cpwright wants to merge 12 commits into
Draft
Conversation
…rt keys-not-present family
…rderedLongSet signature
There was a problem hiding this comment.
Pull request overview
Expands rowset test coverage across shift handling, row-sequence navigation, and internal rowset representations.
Changes:
- Adds edge-case and model-based tests for
SortedRanges, RSP bitmaps, andSingleRange. - Covers shift-data builders, iterator behavior, serialization, chunk conversion, and cardinality caches.
- Exercises tracking and writable rowset APIs.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
RowSetShiftDataTest.java |
Tests shift application, builders, and intersections. |
RowSetShiftDataSmartCoalescingBuilderTest.java |
Tests smart shift coalescing. |
SortedRangesRowSequenceClampTest.java |
Verifies sliced sequence clamping. |
SortedRangesPredicateTest.java |
Covers overlap and subset predicates. |
SortedRangesInvertTest.java |
Tests key-to-position inversion. |
SortedRangesCompactTest.java |
Verifies safe compaction. |
SingleRangeEncodingTest.java |
Tests encoding variants and boundaries. |
ShiftedRowSequenceWrapTest.java |
Covers nested shift composition. |
RspBitmapBuilderSequentialChunkTest.java |
Tests chunk appends and container donation. |
RspArrayPredicateTest.java |
Covers RSP containment predicates. |
RspArrayNavigationTest.java |
Tests navigation and row-sequence views. |
RspArrayCardinalityCacheTest.java |
Verifies cardinality-cache behavior. |
RowSetUtilsTest.java |
Expands utility-function coverage. |
RowSetImplSurfaceTest.java |
Covers writable and tracking APIs. |
RowSequenceAbortAndResumeTest.java |
Tests iteration abort and resume semantics. |
RowKeyChunkUtilsTest.java |
Adds conversion boundary cases. |
ExternalizableRowSetUtilsTest.java |
Tests compressed serialization round trips. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.