moved part of FileDataCache implementation into source file#651
moved part of FileDataCache implementation into source file#651firewave wants to merge 2 commits into
FileDataCache implementation into source file#651Conversation
firewave
force-pushed
the
cache-oimpl
branch
2 times, most recently
from
81da2bb to
7b8c778
Compare
| mData.clear(); | ||
| } | ||
|
|
||
| bool getFileId(const std::string &path, FileID &id) |
There was a problem hiding this comment.
should it be static also? the declaration is static as far as I can tell.
There was a problem hiding this comment.
Yes. That should have been caught by the compiler or clang-tidy though.
There was a problem hiding this comment.
I am confused by your comments.. do you plan to add the static keyword or is there some reason to not add it?
There was a problem hiding this comment.
It is already static in the forward declaration - see the other comment thread.
There was a problem hiding this comment.
so the reason you don't write static here is because that would be redundant?
To me it would feel preferable to match the prototype and write the static keyword even if it's technically redundant.
There was a problem hiding this comment.
Now I am finally getting what your are aiming for. I have never seen code written like that. Usually static (like extern) is only applied to the declaration. It is valid code though and does not even trigger a warning (which is surprising to me).
| static bool getFileId(const std::string &path, FileID &id); | ||
|
|
There was a problem hiding this comment.
Ah - I forward declared it so the code doesn't need to be moved.
|
Would have been great to have this land before the release. |
I thought of this as a refactoring that is not a hurry.. |
2 participants
No description provided.