[mptre]

Unused parameters annotated with the unused attribute were reported as they could be declared as pointer to const, while [[maybe_unused]] parameters were not.

[dmcppcheck]

AI review

I found no problems that need fixing, and the change looks correct.

The change to getVariableTokenAfterAttributes reaches further than the parameter case the PR is about. It also fixes local variables and struct members whose declaration lists several names, because the attribute used to land on the next name:

• int x __attribute__((unused)), y; used to mark y and report unusedVariable for x. Now x is marked and that false positive is gone.
• struct S { int a __attribute__((unused)), b; }; used to mark b and hide its warning. Now S::b is correctly reported as unusedStructMember.

Neither of these effects is covered by a test. A tokenizer or unused-variable test for them would protect the fix from regressions.

One more effect: isMaybeUnused() is now true for local variables with __attribute__((unused)), so constVariable and unreadVariable are skipped for them in the same way as for [[maybe_unused]]. That is consistent with the existing behaviour.

Testing

• I built cppcheck and testrunner from pr/ and cppcheck from base/; both built without errors.

• ./testrunner TestOther TestTokenizer TestUnusedVar TestSymbolDatabase TestUnusedFunctions TestUnusedPrivateFunction TestGarbage TestVarID ran 1841 tests with 0 failures.

• I ran both binaries with cppcheck -q --enable=all --inconclusive on a scratch file with these cases:

  • the attribute before and after the parameter name
  • __unused__, and unused combined with aligned(4)
  • used, which still warns as expected
  • an unnamed attributed parameter
  • a function pointer parameter
  • an array parameter
  • a parameter that is actually dereferenced (now suppressed, the same as [[maybe_unused]] today)
  • local declarations with several names
  • struct members
  • sizeof(int __attribute__((unused)))

  Differences from base:

  • All constParameterPointer/constParameter reports for __attribute__((unused)) parameters are gone, which is the intended fix.
  • a.c:11:9: style: Unused variable: x [unusedVariable] for int x __attribute__((unused)), y; is no longer reported (correct).
  • struct member 'S::b' is never used. [unusedStructMember] for struct S { int a __attribute__((unused)), b; }; is now reported (correct; base had marked b).

• With --dump, for the unnamed parameter in void f(int __attribute__((unused)), int *q) the attribute now lands on the type token int. Base put it on the next parameter q, which was wrong. I found no check that is affected by this.

• I found no crashes or hangs.

---

Automated review of 3c56ef2 by Claude. The pull request was built and tested locally.

[dmcppcheck]

AI review

Matching , here also changes declarations with several names, not just parameters. int x __attribute__((unused)), y; used to mark y (giving a false unusedVariable for x), and struct S { int a __attribute__((unused)), b; }; used to mark b (hiding unusedStructMember for b). Both are now right, but no test covers them. A test in TestUnusedVar, or a tokenizer test that checks which token gets isAttributeUnused, would protect this fix.

[dmcppcheck]

Test results for commit 3c56ef2 (tools/test-my-pr.py, main compared to this PR):

Test: http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-8976/
packages: 1000
Differing warnings: 929 (+0 -929)
AI review: 50 improvement (http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-8976/2026-10-28_19-27-18-3c56ef2e9d4f-review.txt)
Timing: -0.1% (http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-8976/2026-10-28_19-27-18-3c56ef2e9d4f_timing.html)

_{Posted automatically by the cppcheck PR test runner. +N: warnings only with this PR, -N: warnings only with main. The AI review is written by Claude and can be wrong.}