Skip to content

refactor(search): decompose 520-line monolithic search handler into focused per-source functions (closes #99) #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpak-ai merged 6 commits into from
Jun 11, 2026
+1,214 −490
Merged

refactor(search): decompose 520-line monolithic search handler into focused per-source functions (closes #99) #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e29cf8
fix: initial implmentation
bradjin8 Jun 10, 2026
4488963
fix: typecheck error
bradjin8 Jun 10, 2026
d08ca43
fix: add test for search helpers
bradjin8 Jun 10, 2026
dd5a01b
fix; review findings
bradjin8 Jun 10, 2026
5ce7702
fix: nitpack and outside diff comments
bradjin8 Jun 10, 2026
dbb094d
fix: Do not expose raw exception text in API warnings.
bradjin8 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
# Pytest fixtures (tests/conftest.py) build a temp workspaceStorage and
# exercise Flask routes via app.test_client(). Only listed files — not
# `pytest tests/` — to avoid re-collecting unittest.TestCase classes above.
run: python -m pytest tests/test_api_endpoints.py tests/test_pdf_export.py -v --tb=short
run: python -m pytest tests/test_api_endpoints.py tests/test_pdf_export.py tests/test_search_helpers.py -v --tb=short

# ── PyInstaller desktop build (Windows only, once per workflow) ────────
# Closes #44. Builds the onedir bundle and smoke-tests --help so the
Expand Down
Loading
Loading