Add Pyright coverage for cppa_user_tracker and cppa_pinecone_sync#284
Add Pyright coverage for cppa_user_tracker and cppa_pinecone_sync#284snowfox1003 wants to merge 2 commits into
cppa_user_tracker and cppa_pinecone_sync#284Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughModernize type annotations to Python 3.10+ union/built-in generics across tracker and Pinecone modules and expand Pyright's include list and documentation to cover additional packages. ChangesType Annotation Modernization and Pyright Scope Expansion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
… include None options
Summary
Extend static type checking to
cppa_user_tracker(identity hub) andcppa_pinecone_sync(Pinecone ingestion pipeline). Both apps are added topyrightconfig.jsonand now pass Pyright at the configuredbasicstrictness with zero errors.cppa_user_tracker# pyright: ignore[reportCallIssue]onTextChoicesmembers (same pattern asgithub_activity_tracker)emailsonBaseProfileviaTYPE_CHECKING+Manager["Email"]get_or_create_slack_userinput toSlackUserPayload | dict[str, Any]; normalizeOptional[X]→X | Nonecppa_pinecone_syncTextSplitter._keep_separatorannotation intext_chunking.pyDocument.metadata, sync document helpers (list[Document]), andPreprocessFnboundaries_resolve_preprocessor,add_arguments, preprocessor field guard)Docs updated to list all six Pyright-scoped apps.
Apps touched
cppa_user_trackercppa_pinecone_syncpyrightconfig.json(repo root)docs/(Pyright scope notes)README.mdTest plan
python -m pytest cppa_user_tracker/ cppa_pinecone_sync/(168 passed)uv run pyright(0 errors)lint-imports(if imports or cross-app coupling changed) —TYPE_CHECKING-only import fromcppa_slack_tracker.api_schemas; no runtime cross-app coupling changeDocs / coupling
python scripts/generate_service_docs.pyrun (ifservices.pyorcore/protocols.pychanged)docs/updated (if behavior or ops changed)Closes #266
Summary by CodeRabbit
Bug Fixes
Documentation
Chores