fix(tabs): handle ctrl/shift+click on links, clear address bar on new tab#154
Merged
Conversation
… tab Ctrl/Cmd+click on internal links now opens a background tab instead of falling through to the window-open handler and spawning a new window (#112, #113). Shift+click opens a new window containing just that page, and deep-linked windows no longer restore or overwrite the saved tab session via a new ephemeral flag (#116). The address bar syncs to the active tab, clearing on a fresh tab and showing the query on a search tab (#111).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the modifier-click + tab-navigation bug cluster reported by @raindropsfromsky. #113 was already closed as a duplicate of #112.
Root cause
Ctrl/Shift+click on internal links was never handled by the tab layer. Vue Router's
<router-link>ignores modifier clicks, so they fell through to the main-process window-open handler and spawned a new window. Only middle-click had been wired up to open a tab.Changes
parseInternalLinkRoutehelper used by the middle/ctrl/shift click paths; updatedDESIGN-TABS.md.Verification
ESLint clean. Each modifier-click path traced and store getters/mutations confirmed. Not runtime click-tested (GUI interaction).
Fixes #111
Fixes #112
Fixes #116