Skip to content

fix(tabs): handle ctrl/shift+click on links, clear address bar on new tab#154

Merged
countgitmick merged 1 commit into
developmentfrom
ship/tab-modifier-clicks
Jun 14, 2026
Merged

fix(tabs): handle ctrl/shift+click on links, clear address bar on new tab#154
countgitmick merged 1 commit into
developmentfrom
ship/tab-modifier-clicks

Conversation

@countgitmick

Copy link
Copy Markdown
Owner

Addresses the modifier-click + tab-navigation bug cluster reported by @raindropsfromsky. #113 was already closed as a duplicate of #112.

Root cause

Ctrl/Shift+click on internal links was never handled by the tab layer. Vue Router's <router-link> ignores modifier clicks, so they fell through to the main-process window-open handler and spawned a new window. Only middle-click had been wired up to open a tab.

Changes

Verification

ESLint clean. Each modifier-click path traced and store getters/mutations confirmed. Not runtime click-tested (GUI interaction).

Fixes #111
Fixes #112
Fixes #116

… tab

Ctrl/Cmd+click on internal links now opens a background tab instead of falling through to the window-open handler and spawning a new window (#112, #113). Shift+click opens a new window containing just that page, and deep-linked windows no longer restore or overwrite the saved tab session via a new ephemeral flag (#116). The address bar syncs to the active tab, clearing on a fresh tab and showing the query on a search tab (#111).
@countgitmick countgitmick merged commit 31545cb into development Jun 14, 2026
7 checks passed
@countgitmick countgitmick deleted the ship/tab-modifier-clicks branch June 14, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment