CBG-5764: move SafeDocumentName to testing/sgtest - #8686
Draft
torcolvin wants to merge 1 commit into
Draft
Conversation
The helper is needed from base as well as db and rest, and base cannot import either of them. Move it to testing/sgtest, which has no SG dependencies, and leave deprecated aliases behind so existing call sites are untouched - the same shape as the earlier TestUseCouchbaseServer and UnitTestUrlIsWalrus moves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8685.
SafeDocumentNameexisted twice, indband inrest, and was needed frombaseas well - which cannot import either of them. Move it totesting/sgtest, which by design has no SG dependencies, and leave deprecated aliases indbandrestso existing call sites are untouched. Same shape as the earlierTestUseCouchbaseServer/UnitTestUrlIsWalrusmoves.The
sgtestversion takestesting.TBlike the rest of that package; the aliases keep*testing.T.Stack
_mouprevious values describing one mutationSafeDocumentNametotesting/sgtestWriteUpdateXattrOnly_mouwhosepRevis a made-up zero🤖 Generated with Claude Code