Skip to content

CBG-5715: rename doc_write_conflicts to doc_write_conflict - #8651

Open
torcolvin wants to merge 1 commit into
CBG-5715-02-serialized-json-paramsfrom
CBG-5715-03-doc-write-conflict
Open

CBG-5715: rename doc_write_conflicts to doc_write_conflict#8651
torcolvin wants to merge 1 commit into
CBG-5715-02-serialized-json-paramsfrom
CBG-5715-03-doc-write-conflict

Conversation

@torcolvin

@torcolvin torcolvin commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CBG-5715

Split out of #8589 — stack 3/9, based on #8650.

The field is serialized from ReplicationStatus.DocWriteConflict, whose JSON tag is doc_write_conflict (db/sg_replicate_cfg.go:1405), so the spec documented a property name that never appears in a response.

Pre-review checklist

  • Logging sensitive data? N/A — docs only
  • Updated relevant information in the API specifications in docs/api

🤖 Generated with Claude Code

@factory-droid

factory-droid Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Droid finished @torcolvin's task —— View job


Phase 2 validation complete.

LGTM — this schema rename aligns the OpenAPI property name with the Go JSON field tag (doc_write_conflict). No issues found in the change.

Inline comments: none.

bbrks
bbrks previously approved these changes Aug 24, 2026
The field is serialized from `ReplicationStatus.DocWriteConflict`, whose
JSON tag is `doc_write_conflict` (db/sg_replicate_cfg.go), so the spec
documented a property name that never appears in a response.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 24, 2026 17:42
@torcolvin
torcolvin force-pushed the CBG-5715-03-doc-write-conflict branch from 3001bff to fabf711 Compare August 24, 2026 17:42
@torcolvin
torcolvin requested a review from a team August 24, 2026 17:42
@github-actions

Copy link
Copy Markdown

Redocly previews

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects the OpenAPI replication status schema property name to match the serialized JSON field.

Changes:

  • Renamed doc_write_conflicts to doc_write_conflict.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bbrks bbrks removed their assignment Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants